docs(guide): redraw agent-skills.md's tree from disk - #8007
Merged
Conversation
skills/objectui/rules/ and guides/ drifted from the tree agent-skills.md drew: #7251 moved rules/no-touch-zones.md and guides/console-development.md out to the repo-internal .claude/skills/objectui-contributor/ skill, and guides/app-composition.md landed without ever being added to the drawn tree. Redraw both subtrees from `find skills/objectui -type f`, and add a paragraph saying where the two contributor-only files went and why (a customer install has no apps/console/ or packages/components/src/ui/). ci-cd-pipeline.md:581 is deliberately left unchanged: re-running node scripts/check-skills-paths.mjs today confirms the baseline still carries exactly one entry (88/89 stated paths resolve across 20 guide files; 1 baselined), matching the note in scripts/skills-path-baseline.json that the entry was re-stated under the guide's post-move key rather than deleted. The sentence at :581 never named the guide's directory or the moved-to path, so nothing in it went stale. evals/console-development.json is confirmed gone from disk, but the tree never listed individual eval filenames to begin with, so there was no row to remove. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MM7kaS4dPpYHV5BsMyu4tQ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7362
What was stale
content/docs/guide/agent-skills.mddrew the skill's layout as an ASCII tree that no longer matchedskills/objectui/**on disk:rules/no-touch-zones.mdandguides/console-development.mdwere still drawn — both moved to.claude/skills/objectui-contributor/in Skills optimization flight — skills/objectui: RESTRUCTURE (≈ −21,600 tok of 64,022, −34%) — ~19% of the package is addressed at a contributor to this repo (console-development.md, no-touch-zones.md, half of architecture.md), one rule stated up to four times, 11 vestigial guide frontmatters, and three evals that fail correct answers #7251.guides/app-composition.md(a real, current guide) was never drawn at all — it landed without the tree being updated.Disk listing (
find skills/objectui -type f | sort)(
.claude/skills/objectui-contributor/holdsSKILL.md,guides/console-development.md,rules/no-touch-zones.md— the two files' actual current home, matchingskills/objectui/README.md's own already-current tree, which this PR's redraw mirrors.)Redrawn tree (
agent-skills.md)Added a short paragraph after it saying where
no-touch-zones.mdandconsole-development.mdwent and why: a customer install of the published skill never hasapps/console/orpackages/components/src/ui/, which is what those two files are about, so they stayed behind as contributor-only guidance in.claude/skills/objectui-contributor/rather than shipping to every consumer.Tree-resolution loop (every row → a path that exists under
skills/objectui/), before and after — a one-off shell check, not a new gate (the ASCII-tree gate gap is already #7358's other side / #7362's own "why no gate caught it" section):origin/main:content/docs/guide/agent-skills.md): 14/16 resolve, 2 missing —skills/objectui/rules/no-touch-zones.md,skills/objectui/guides/console-development.md.evals/console-development.json: confirmed gone from disk. The tree never listed individual eval filenames to begin with (only theevals/ # Machine-checkable prompts (one per guide)comment line), so there was no row to delete.ci-cd-pipeline.md:581— left unchanged, on purposeThe triage comment's boundary was right: the card's own claim that the baseline is "now empty" is false. Re-running the gate today:
scripts/skills-path-baseline.jsoncarries exactly oneallowedMissingentry, keyed to the guide's current, post-move path (.claude/skills/objectui-contributor/guides/console-development.md→ tokenapps/console/src/context/), with its own note confirming it was re-stated under that key after #7358 widenedSCAN_ROOTS, never deleted.The sentence at
ci-cd-pipeline.md:579-582reads:Checked both claims it makes against today's truth:
console-development.md, with no directory prefix — it never claimed a location, so the Skills optimization flight — skills/objectui: RESTRUCTURE (≈ −21,600 tok of 64,022, −34%) — ~19% of the package is addressed at a contributor to this repo (console-development.md, no-touch-zones.md, half of architecture.md), one rule stated up to four times, 11 vestigial guide frontmatters, and three evals that fail correct answers #7251 move left nothing in this sentence to correct.apps/console/src/context/, is the directory the guide argues does not exist — unrelated to the guide's own location, and it hasn't moved.Conclusion: no edit was needed here. This is the "if any" case the triage comment flagged as possible — verified rather than assumed, and left alone rather than force-editing a correct sentence.
Gates
node scripts/check-skills-paths.mjs88/89 stated path(s) resolve across 20 guide file(s); 1 baselinednode scripts/check-doc-links.mjsLinks are valid across 17 scan roots.pnpm check:doc-fencespnpm check:doc-snippetsPRECONDITION NOT MET): 28 packages + closure unbuilt in this worktree. In scope (neither file is inUNGATED_DOCS, both are walked), but neither touched file contains an actualts/tsxcode fence (ci-cd-pipeline.mdhas one prose mention of the marker at an untouched line, not a fence), so this change carries no snippet-compile risk; deferred to CI's full build rather than a 28-package scoped build for a docs-only, no-fence diff.pnpm check:control-bytesnode scripts/check-changeset-presence.mjs0 changeset(s) added/No source or published contract of a released package changed, none owed (docs-only)node scripts/check-governed-queue-guard.mjs --test(both paths)NOT GOVERNED — 2 path(s) checked against 5 governed surface(s); none matchedpnpm exec vitest run scripts/__tests__/doc-version-claims.test.ts scripts/__tests__/check-skills-paths.test.ts2 passed (2),66 passed (66)pnpm exec vitest run scripts/__tests__/ci-cd-pipeline-doc.test.ts(reader, since it pins this same page)1 passed (1),40 passed (40)Readers (
git grep -l 'agent-skills.md\|ci-cd-pipeline.md' -- scripts/ .github/ packages/):.github/workflows/changeset-release.yml,.github/workflows/dependabot-auto-merge.yml,.github/workflows/lint.yml, and tenscripts/__tests__/*.test.tsfiles includingci-cd-pipeline-doc.test.ts(run above, unaffected — I did not edit that file).CI note:
Live E2E (informational)is expected red on every branch today for an upstream reason unrelated to this change (objectui#7990 / objectstack#16186).Out of scope
Filed objectui#8006:
ci-cd-pipeline.md:551("reads every markdown file underskills/") still undercounts the scan surface after #7358 added.claude/skills/. Different line/sentence from this card's boundary,findinglabel, unassigned.🤖 Generated with Claude Code
https://claude.ai/code/session_01MM7kaS4dPpYHV5BsMyu4tQ